performance(sierra-gas): Compute topological order for prepare_wallet once. #8478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc
branch
from
9e583b7 to
4076e3f
Compare
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-gas_compute_topological_order_for_prepare_wallet_once
branch
from
4137255 to
13b0838
Compare
This was referenced Sep 29, 2025
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-gas_compute_topological_order_for_prepare_wallet_once
branch
from
13b0838 to
b76eb60
Compare
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc
branch
from
4076e3f to
dfc6e2b
Compare
TomerStarkware
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
@TomerStarkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-gas_compute_topological_order_for_prepare_wallet_once
branch
from
b76eb60 to
580ae88
Compare
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc
branch
from
dfc6e2b to
f3f6eb1
Compare
… once. SIERRA_UPDATE_PATCH_CHANGE_TAG=Just performance gain - no interface effect.
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-gas_compute_topological_order_for_prepare_wallet_once
branch
from
580ae88 to
c13f2c4
Compare
orizi
force-pushed
the
gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc
branch
from
f3f6eb1 to
979a421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIERRA_UPDATE_PATCH_CHANGE_TAG=Just performance gain - no interface effect.